Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: indent subsection about references in nested tables #2161

Closed
wants to merge 2 commits into from

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Dec 18, 2024

Description

References are described in the section right above.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 3aaa338
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6762a5ea104e20000841b40e
😎 Deploy Preview https://deploy-preview-2161--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -227,9 +227,6 @@ You are able to bring your own `row_key` by adding a `_dlt_id` column/field to y

`merge` write disposition requires an additional nested reference that goes from **nested** to **root** table, skipping all parent tables in between. This reference is created by [adding a column with a hint](incremental-loading.md#forcing-root-key-propagation) `root_key` (named `_dlt_root_id` by default) to nested tables.

### Table references
You can annotate tables with table references. This feature is coming soon.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joscha thanks for the PR. The section above describes nested references, not table references, if you read the whole references section you can see that this differentiation is done at the beginning of the section. We have a conceptual implementation of these table references but they are not available in the core library yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - should this be #### then, to be one level below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it in 3aaa338

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not really, ### is correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I don't think it makes sense:

2024-12-18_10-52

@joscha joscha changed the title docs: remove outdated subsection docs: indent subsection about references in nested tables Dec 18, 2024
@joscha joscha closed this Dec 18, 2024
@joscha joscha deleted the patch-1 branch December 18, 2024 10:53
@joscha
Copy link
Contributor Author

joscha commented Dec 18, 2024

refs #1855, #1647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants